-
Notifications
You must be signed in to change notification settings - Fork 11
Issue 168 #176
base: master
Are you sure you want to change the base?
Issue 168 #176
Conversation
@@ -23,6 +23,16 @@ def send_email(sender, to, subject, body, html=None): | |||
mail.send(msg) | |||
|
|||
|
|||
# EDIT form choices | |||
# https://github.com/hasgeek/hacknight/issues/168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Krace, you need to use workflow actions. The workflow object can automatically generate a list of available actions for the current state. See Kharcha for an example of how to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, these choices should NOT be in the Edit form. They should be actions from the sidebar on the event page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Krace, this pull request needs to be rebased. |
Can you update this pull request to prepare for merging? |
@@ -10,7 +10,7 @@ | |||
|
|||
STATUS_CHOICES = [ | |||
(EVENT_STATUS.DRAFT, 'Draft'), | |||
(EVENT_STATUS.PUBLISHED, 'Published'), | |||
(EVENT_STATUS.PUBLISHED, 'Public'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this flag also to PUBLIC (here and with all references).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change public
to PUBLIC
or active
to PUBLIC
? Should we capitalise ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh got it, EVENT_STATUS.PUBLIC
Fixes issue #168 .